Skip to content

chore: remove mempool tracking config mutation method #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xdustinface merged 1 commit into from
Jan 20, 2026
Merged

chore: remove mempool tracking config mutation method #373

xdustinface merged 1 commit into from
Jan 20, 2026

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Jan 19, 2026 •
edited by coderabbitai bot
Loading

Part of the config builder update. Since the config is gonna become immutable once is built to ensure is valid while it is alive this method must be removed

Summary by CodeRabbit

  • Breaking Changes

    • Removed mempool tracking functionality from the API.

  • Documentation

    • Updated API documentation to reflect removal of mempool operations. Total available functions reduced from 67 to 66.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This change removes mempool tracking initialization functionality from the public API and implementation layers. The dash_spv_ffi_client_enable_mempool_tracking function, associated enum, and related methods are deleted from documentation, headers, FFI implementation, core client code, and tests.

Changes

Cohort / File(s) Summary
Documentation
dash-spv-ffi/FFI_API.md		 Removed Mempool Operations section and function entry; updated Table of Contents; function count decreased from 67 to 66
FFI Header
dash-spv-ffi/include/dash_spv_ffi.h		 Removed public function dash_spv_ffi_client_enable_mempool_tracking; relocated FFIMempoolStrategy enum (moved after DashSpvValidationMode)
FFI Implementation
dash-spv-ffi/src/client.rs		 Removed FFI function dash_spv_ffi_client_enable_mempool_tracking and its error handling logic; removed FFIMempoolStrategy from public imports
Core Client Implementation
dash-spv/src/client/mempool.rs		 Removed enable_mempool_tracking async method and associated mempool filter initialization logic
Tests
dash-spv/src/client/mod.rs		 Removed call to enable_mempool_tracking in test setup; changed client binding from mutable to immutable

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A path through mempool once did glow,
Now cleared away to help code flow,
Six functions down, the API's clean,
Simplest changes you've ever seen! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately and specifically describes the main change: removing a method that mutates configuration (enable_mempool_tracking).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini mentioned this pull request Jan 19, 2026
Draft
@xdustinface xdustinface changed the title chore: removed config mutation method in client chore: remove mempool tracking config mutation method Jan 20, 2026
@xdustinface xdustinface merged commit 8236af5 into v0.42-dev Jan 20, 2026
53 checks passed
@xdustinface xdustinface deleted the chore/removed-mempool-tracking-mutation branch January 20, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xdustinface xdustinface xdustinface approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZocoLini @xdustinface